Add a `kola` verb #85

cgwalters · 2018-09-14T16:39:28Z

Blocked by coreos/fedora-coreos-config#2

cgwalters · 2018-09-18T14:36:19Z

cgwalters · 2018-09-21T14:07:39Z

Lifting WIP on this, but we have a dependency in coreos/mantle#920 at least...there's general nontrivial work to teach kola about the 3 distributions.

cgwalters · 2018-10-10T17:49:00Z

coreos/mantle#922

arithx · 2018-10-10T17:52:52Z

coreos/mantle#922 has landed (I had forgotten to actually merge it)

dustymabe · 2018-10-11T13:43:07Z

should we wait on the discussion in #163 since i think it has implications?

poor PR :(

jlebon · 2019-05-16T17:49:41Z

So now with #524, let's (1) switch this to run the unpriv tests, (2) get it in, and (3) update coreos/fedora-coreos-pipeline#31 to leverage it?

jlebon · 2019-05-16T17:56:26Z

should we wait on the discussion in #163 since i think it has implications?

I'm not sure if that discussion necessarily blocks this patch though, right? We can assume we have kola in the container, and we can discuss in that ticket how it gets in there. :)

dustymabe · 2019-05-16T18:13:51Z

should we wait on the discussion in #163 since i think it has implications?

I'm not sure if that discussion necessarily blocks this patch though, right? We can assume we have kola in the container, and we can discuss in that ticket how it gets in there. :)

I think at some point during that discussion it was up in the air whether we wanted it to be a completely separate container or not. I think at this point it is safe to assume regardless of how we build it we will include it in cosa. I agree that we don't need to block.

dustymabe · 2019-05-16T18:14:27Z

src/cmd-kola

+    fatal "No latest build"
+fi
+
+exec sudo kola -b rhcos --tapfile test.tap --qemu-image ${latest_qcow} "$@"


is -b rhcos important here? is there a -b fcos ?

Distribution flags are important. That said, we should make it a flag on the command and just have it default to one of fcos/rhcos

I'd vote for changing kola to look for rhcos- or fcos- as a prefix in the image name for now; that same thing would also be useful for ignition spec version handling.

Prefix based detection WFM.

And yes, when --ignition-version v2 will need to be specified when running RHCOS until spec 3.0.0 lands there. For FCOS we don't need to specify that parameter as it defaults to v3 on that distribution.

Would probably be good to have command-line overrides as well (at least on Ignition version) so that it would be possible to test Ignition spec 3.0.0 in RHCOS without having to modify cmd-run.

I added the auto-detect logic in the command itself for now with a XXX to upstream it into kola.

jlebon · 2019-05-24T21:40:14Z

OK, I rebased this now!

$ ca kola run -p qemu-unpriv
...
+ exec sudo kola -b fcos --tapfile test.tap --qemu-image builds/30.8/fedora-coreos-30.8-qemu.qcow2 run -p qemu-unpriv
=== RUN   fcos.basic
=== RUN   rpmostree.upgrade-rollback
=== RUN   coreos.selinux.enforce
=== RUN   coreos.ignition.sethostname
=== RUN   rpmostree.status
=== RUN   coreos.auth.verify
=== RUN   coreos.ignition.groups
=== RUN   coreos.selinux.boolean
=== RUN   rhcos.selinux.boolean.persist
=== RUN   coreos.ignition.once
=== RUN   systemd.sysusers.gshadow
=== RUN   fcos.basic/ReadOnly
=== RUN   fcos.basic/Useradd
=== RUN   fcos.basic/MachineID
=== RUN   fcos.basic/PortSSH
=== RUN   fcos.basic/DbusPerms
=== RUN   fcos.basic/ServicesActive
--- PASS: fcos.basic (29.76s)
    --- PASS: fcos.basic/ReadOnly (0.18s)
    --- PASS: fcos.basic/Useradd (0.69s)
    --- PASS: fcos.basic/MachineID (0.18s)
    --- PASS: fcos.basic/PortSSH (0.21s)
    --- PASS: fcos.basic/DbusPerms (0.43s)
    --- PASS: fcos.basic/ServicesActive (0.24s)
--- PASS: coreos.ignition.groups (26.28s)
--- PASS: rhcos.selinux.boolean.persist (47.87s)
--- PASS: coreos.selinux.boolean (44.80s)
--- PASS: coreos.ignition.sethostname (25.18s)
--- PASS: coreos.auth.verify (28.04s)
--- PASS: rpmostree.status (25.78s)
--- PASS: systemd.sysusers.gshadow (26.54s)
--- PASS: coreos.selinux.enforce (45.81s)
=== RUN   rpmostree.upgrade-rollback/upgrade
=== RUN   rpmostree.upgrade-rollback/rollback
--- PASS: rpmostree.upgrade-rollback (76.25s)
    --- PASS: rpmostree.upgrade-rollback/upgrade (24.51s)
    --- PASS: rpmostree.upgrade-rollback/rollback (26.50s)
--- PASS: coreos.ignition.once (43.54s)
PASS, output in tmp/kola

Let's get this in?

jlebon · 2019-05-24T21:44:16Z

(Though I actually didn't test it on RHCOS yet.)

src/cmdlib.sh

cgwalters · 2019-05-24T23:42:01Z

This looks sane to me!

arithx

Generally LGTM, couple questions.

arithx · 2019-05-28T17:08:28Z

src/cmd-kola

+set -x
+
+# shellcheck disable=SC2086
+exec sudo kola $distro --output-dir tmp/kola --tapfile test.tap --qemu-image "${latest_qcow}" "$@"


We don't have anything keying on the tapfile in this command, maybe drop it and let things specify it directly if they care about it?

Might be worthwhile to default to some extra parallel threads (via --parallel <num>).

Thanks, dropped the --tapfile bit!

Might be worthwhile to default to some extra parallel threads (via --parallel <num>).

I left this off for now. It's tricky to get right to match all possible environments. See e.g. get_libvirt_smp_arg in virt-install. Hmm, though I guess I could split that out into a separate Python script and here shell out to it?

Probably fair to leave out parallel for now, it can be specified on the command-line and has the extra trickery around it as you mentioned.

miabbott · 2019-05-28T20:04:54Z

(Though I actually didn't test it on RHCOS yet.)

qemu_unpriv will likely fail with RHCOS due to https://github.com/coreos/mantle/issues/999

arithx · 2019-05-28T20:05:48Z

(Though I actually didn't test it on RHCOS yet.)

qemu_unpriv will likely fail with RHCOS due to coreos/mantle#999

This verb doesn't specify the platform (which defaults to qemu not qemu-unpriv).

dustymabe

need to make cmd-kola executable.. otherwise you get: Unknown command: kola

src/cmd-kola

jlebon · 2019-05-29T13:27:28Z

need to make cmd-kola executable

Huh, I'm not sure how I didn't hit that... anyway, fixed!

dustymabe · 2019-05-29T13:47:08Z

src/cmdlib.sh

+    latest=$(get_latest_build)
+    if [ -n "$latest" ]; then
+        # shellcheck disable=SC2086
+        ls builds/${latest}/*-qemu.qcow2


not anything we need to do here but FYI if you have run cosa compress this will fail.

dustymabe

LGTM

dustymabe · 2019-05-29T13:52:39Z

LGTM

if only shellcheck were happy

This is the first place we're wrapping mantle via our main entrypoint, and hopefully we'll increase that. Example usage: `coreos-assembler kola run rhcos.basic`. Requires: coreos/mantle#920

jlebon · 2019-05-29T14:03:47Z

OK right, this code predates the addition of ShellCheck. Should hopefully be happy now!

dustymabe · 2019-05-29T14:08:21Z

haha - i just thought about it cosa kola is very close to coca cola :)

cgwalters force-pushed the cmd-test branch from afff649 to 00c953a Compare September 18, 2018 14:35

cgwalters mentioned this pull request Sep 18, 2018

OS ID detection improvements coreos/mantle#918

Closed

cgwalters closed this Sep 18, 2018

cgwalters reopened this Sep 18, 2018

dustymabe added the WIP PR still being worked on label Sep 19, 2018

cgwalters force-pushed the cmd-test branch from 00c953a to c38a300 Compare September 21, 2018 14:05

cgwalters changed the title ~~WIP: Add a kola verb~~ Add a kola verb Sep 21, 2018

cgwalters removed the WIP PR still being worked on label Sep 21, 2018

dustymabe added the hold waiting on something label Oct 11, 2018

cgwalters mentioned this pull request Mar 5, 2019

[WIP]: Jenkinsfile: add Testing stage coreos/fedora-coreos-pipeline#31

Closed

dustymabe reviewed May 16, 2019

View reviewed changes

jlebon force-pushed the cmd-test branch 4 times, most recently from 17a0dec to 859be8c Compare May 24, 2019 21:39

jlebon force-pushed the cmd-test branch 2 times, most recently from d9a8b27 to 3577116 Compare May 24, 2019 22:29

cgwalters commented May 24, 2019

View reviewed changes

src/cmdlib.sh Outdated Show resolved Hide resolved

jlebon force-pushed the cmd-test branch from 3577116 to f4a5d8e Compare May 25, 2019 14:28

jlebon removed the hold waiting on something label May 27, 2019

arithx approved these changes May 28, 2019

View reviewed changes

jlebon force-pushed the cmd-test branch from f4a5d8e to 5571445 Compare May 28, 2019 19:05

dustymabe reviewed May 28, 2019

View reviewed changes

src/cmd-kola Outdated Show resolved Hide resolved

src/cmd-kola Outdated Show resolved Hide resolved

jlebon force-pushed the cmd-test branch from 5571445 to 6fdd8ad Compare May 29, 2019 13:24

dustymabe reviewed May 29, 2019

View reviewed changes

dustymabe approved these changes May 29, 2019

View reviewed changes

Add a kola verb

68325f0

This is the first place we're wrapping mantle via our main entrypoint, and hopefully we'll increase that. Example usage: `coreos-assembler kola run rhcos.basic`. Requires: coreos/mantle#920

jlebon force-pushed the cmd-test branch from 6fdd8ad to 68325f0 Compare May 29, 2019 14:03

dustymabe merged commit 0c4fb22 into coreos:master May 29, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add a `kola` verb #85

Add a `kola` verb #85

cgwalters commented Sep 14, 2018

cgwalters commented Sep 18, 2018

cgwalters commented Sep 21, 2018

cgwalters commented Oct 10, 2018

arithx commented Oct 10, 2018

dustymabe commented Oct 11, 2018

jlebon commented May 16, 2019

jlebon commented May 16, 2019

dustymabe commented May 16, 2019

dustymabe May 16, 2019

arithx May 16, 2019

cgwalters May 16, 2019

arithx May 16, 2019

arithx May 16, 2019

jlebon May 24, 2019

jlebon commented May 24, 2019

jlebon commented May 24, 2019

cgwalters commented May 24, 2019

arithx left a comment

arithx May 28, 2019

jlebon May 28, 2019

arithx May 28, 2019

miabbott commented May 28, 2019

arithx commented May 28, 2019

dustymabe left a comment

jlebon commented May 29, 2019

dustymabe May 29, 2019

dustymabe left a comment

dustymabe commented May 29, 2019

jlebon commented May 29, 2019

dustymabe commented May 29, 2019

Add a kola verb #85

Add a kola verb #85

Conversation

cgwalters commented Sep 14, 2018

cgwalters commented Sep 18, 2018

cgwalters commented Sep 21, 2018

cgwalters commented Oct 10, 2018

arithx commented Oct 10, 2018

dustymabe commented Oct 11, 2018

jlebon commented May 16, 2019

jlebon commented May 16, 2019

dustymabe commented May 16, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jlebon commented May 24, 2019

jlebon commented May 24, 2019

cgwalters commented May 24, 2019

arithx left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

miabbott commented May 28, 2019

arithx commented May 28, 2019

dustymabe left a comment

Choose a reason for hiding this comment

jlebon commented May 29, 2019

Choose a reason for hiding this comment

dustymabe left a comment

Choose a reason for hiding this comment

dustymabe commented May 29, 2019

jlebon commented May 29, 2019

dustymabe commented May 29, 2019

Add a `kola` verb #85

Add a `kola` verb #85